-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): reactiveOmit
and reactivePick
support array as second arg
#1742
Conversation
Can you provide the example you are trying to support with this? |
@@ -8,7 +9,7 @@ import { reactiveComputed } from '../reactiveComputed' | |||
*/ | |||
export function reactiveOmit<T extends object, K extends keyof T>( | |||
obj: T, | |||
...keys: K[] | |||
...keys: Array<Many<K>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...keys: Array<Many<K>> | |
...keys: (K | K[])[] |
The abstraction of Many
make understanding it a bit harder. I think it's better to wrote them as literals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Yes the literal meaning is really easier to understand
reactiveOmit
and reactivePick
support array as second arg
Description
Fixed reactiveOmit and reactivePick parameter types not supporting passed arrays
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).